fix(cli): Use pathe instead of node:path
#1514
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
|
Thank you, but I would rather avoid adding another dependency if it's possible! The issue was that the aliases for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes testing issues for the CLI for windows users.
node:pathwithpatheNot sure if this is really important especially since it's an extra dependency for the CLI. But I tried it in one of my side projects and it worked without any issues.
The registry build has the exact same issue so we may be able to do the same there.
P.S.
Didn't add a changeset since there are no user facing changes lmk if I should add one anyways.